Chromium Code Reviews

Issue 2167553002: Custom objdump to enable perf annotation (Closed)

Created:
4 years, 5 months ago by mattloring
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, ofrobots, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Custom objdump to enable perf annotation Allows jitted code to be annotated in perf. To use: 1) Report generated code in code-(pid)-1.asm. perf record -- d8 --print-code --redirect-code-traces script.js 2) Run perf report from the directory containing the above code file. perf report --objdump=v8/tools/objdump-v8 This script supports generated code from both crankshaft or turbofan. BUG= Committed: https://crrev.com/dbba4b40be3beeaf4834c971d88dd94bf43db8f5 Cr-Commit-Position: refs/heads/master@{#37913}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+46 lines, -22 lines)
A + tools/objdump-v8 View 2 chunks +46 lines, -22 lines 1 comment

Messages

Total messages: 15 (8 generated)
mattloring
4 years, 5 months ago (2016-07-20 00:10:06 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-07-20 08:46:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167553002/1
4 years, 5 months ago (2016-07-20 16:56:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 16:58:44 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 16:58:45 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dbba4b40be3beeaf4834c971d88dd94bf43db8f5 Cr-Commit-Position: refs/heads/master@{#37913}
4 years, 5 months ago (2016-07-20 16:59:37 UTC) #13
Benedikt Meurer
4 years, 5 months ago (2016-07-21 03:50:34 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2167553002/diff/1/tools/objdump-v8
File tools/objdump-v8 (right):

https://codereview.chromium.org/2167553002/diff/1/tools/objdump-v8#newcode60
tools/objdump-v8:60: codefile = "code-" + match.group(1) + "-1.asm"
d8 hardcodes code.asm as output, so this will not work for d8 itself. Can you
just fallback to code.asm if the code-<pid>-<isolate>.asm file is not found?

Powered by Google App Engine