ios/web/public/test/earl_grey/web_view_matchers.h - Issue 2167533002: [ios] EarlGrey test for scroll position restoration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/test/earl_grey/web_view_matchers.h

Issue 2167533002: [ios] EarlGrey test for scroll position restoration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/web/ios_web_shell_tests.gyp ('k') | ios/web/public/test/earl_grey/web_view_matchers.mm » ('j') | ios/web/shell/test/earl_grey/shell_matchers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/public/test/earl_grey/web_view_matchers.h

diff --git a/ios/web/public/test/earl_grey/web_view_matchers.h b/ios/web/public/test/earl_grey/web_view_matchers.h

index 9f52db501d10db4127dfd1d101745744eea470a5..2d8182dd598e1f65c4d55daacd9f63db1f69026d 100644

--- a/ios/web/public/test/earl_grey/web_view_matchers.h

+++ b/ios/web/public/test/earl_grey/web_view_matchers.h

@@ -14,6 +14,9 @@ namespace web {

id<GREYMatcher> webViewContainingText(const std::string& text,

web::WebState* webState);

+// Shorthand for matcherForWebViewScrollViewInWebState:.

baxley 2016/07/20 15:27:25 nit: no ':' (comments in the other matchers file d

baxley 2016/07/20 15:27:25 nit: could you add GREYMatchers::, or remove it fr

Eugene But (OOO till 7-30) 2016/07/20 16:09:39 Done.

Eugene But (OOO till 7-30) 2016/07/20 16:09:40 Done.

+id<GREYMatcher> webViewScrollView(web::WebState* webState);

} // namespace web

@interface GREYMatchers (WebViewAdditions)

@@ -22,4 +25,8 @@ id<GREYMatcher> webViewContainingText(const std::string& text,

+ (id<GREYMatcher>)matcherForWebViewContainingText:(const std::string&)text

inWebState:(web::WebState*)webState;

+// Matcher for WKWebView's scroll view.

++ (id<GREYMatcher>)matcherForWebViewScrollViewInWebState:

+ (web::WebState*)webState;

@end

« no previous file with comments | « ios/web/ios_web_shell_tests.gyp ('k') | ios/web/public/test/earl_grey/web_view_matchers.mm » ('j') | ios/web/shell/test/earl_grey/shell_matchers.h » ('J')