[ios] EarlGrey test for scroll position restoration.

[ios] EarlGrey test for scroll position restoration.

BUG=629116
Committed: https://crrev.com/bb00a30f5de32cf70af86737eb3013a7e82e14ce
Cr-Commit-Position: refs/heads/master@{#406588}

[Eugene But (OOO till 7-30), 2016-07-19 22:49:09]

eugenebut@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2016-07-20 15:27:25]

lgtm

https://codereview.chromium.org/2167533002/diff/1/ios/web/public/test/earl_gr...
File ios/web/public/test/earl_grey/web_view_matchers.h (right):

https://codereview.chromium.org/2167533002/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.h:17: // Shorthand for
matcherForWebViewScrollViewInWebState:.
nit: no ':' (comments in the other matchers file doesn't have this).

https://codereview.chromium.org/2167533002/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.h:17: // Shorthand for
matcherForWebViewScrollViewInWebState:.
nit: could you add GREYMatchers::, or remove it from the other comment on line
13.

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/earl_gre...
File ios/web/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/earl_gre...
ios/web/shell/test/earl_grey/shell_matchers.h:14: // Shorthand for
matcherForWebViewScrollView.
nit: Could you add "GREYMatchers::", or remove it from the other methods.

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/web_shel...
File ios/web/shell/test/web_shell_page_state_egtest.mm (right):

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/web_shel...
ios/web/shell/test/web_shell_page_state_egtest.mm:11: #include
"ios/web/public/test/http_server_util.h"
import?

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/web_shel...
ios/web/shell/test/web_shell_page_state_egtest.mm:34: MatchesBlock matches =
^BOOL(id element) {
should this UIView* instead of id? More question than critique. A lot of the
Earl Grey matchers that interact on UI properties use UIView, and ones that do
more generic things on an object (e.g. nil, notNil, ...) use id. Is it because
it's in UIScrollView?

[Eugene But (OOO till 7-30), 2016-07-20 16:09:40]

Thanks!

https://codereview.chromium.org/2167533002/diff/1/ios/web/public/test/earl_gr...
File ios/web/public/test/earl_grey/web_view_matchers.h (right):

https://codereview.chromium.org/2167533002/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.h:17: // Shorthand for
matcherForWebViewScrollViewInWebState:.
On 2016/07/20 15:27:25, baxley wrote:
> nit: could you add GREYMatchers::, or remove it from the other comment on line
> 13.

Done.

https://codereview.chromium.org/2167533002/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.h:17: // Shorthand for
matcherForWebViewScrollViewInWebState:.
On 2016/07/20 15:27:25, baxley wrote:
> nit: no ':' (comments in the other matchers file doesn't have this).

Done.

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/earl_gre...
File ios/web/shell/test/earl_grey/shell_matchers.h (right):

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/earl_gre...
ios/web/shell/test/earl_grey/shell_matchers.h:14: // Shorthand for
matcherForWebViewScrollView.
On 2016/07/20 15:27:25, baxley wrote:
> nit: Could you add "GREYMatchers::", or remove it from the other methods.

Done.

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/web_shel...
File ios/web/shell/test/web_shell_page_state_egtest.mm (right):

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/web_shel...
ios/web/shell/test/web_shell_page_state_egtest.mm:11: #include
"ios/web/public/test/http_server_util.h"
On 2016/07/20 15:27:25, baxley wrote:
> import?
This header does not have any Objective-C code (unless I'm missing something).

https://codereview.chromium.org/2167533002/diff/1/ios/web/shell/test/web_shel...
ios/web/shell/test/web_shell_page_state_egtest.mm:34: MatchesBlock matches =
^BOOL(id element) {
On 2016/07/20 15:27:25, baxley wrote:
> should this UIView* instead of id? More question than critique. A lot of the
> Earl Grey matchers that interact on UI properties use UIView, and ones that do
> more generic things on an object (e.g. nil, notNil, ...) use id. Is it because
> it's in UIScrollView?
UIView does not have |contentOffset| method and I'm not a fan of casting. I
updated the code to follow |matcherForButtonTitle:| approach.

[Eugene But (OOO till 7-30), 2016-07-20 16:09:45]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-07-20 16:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org
Link to the patchset: https://codereview.chromium.org/2167533002/#ps20001
(title: "Addressed review comment")

[commit-bot: I haz the power, 2016-07-20 16:10:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:56:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 16:57:57]

Description was changed from

==========
[ios] EarlGrey test for scroll position restoration.

BUG=629116
==========

to

==========
[ios] EarlGrey test for scroll position restoration.

BUG=629116

Committed: https://crrev.com/bb00a30f5de32cf70af86737eb3013a7e82e14ce
Cr-Commit-Position: refs/heads/master@{#406588}
==========

[commit-bot: I haz the power, 2016-07-20 16:57:58]

Patchset 2 (id:??) landed as
https://crrev.com/bb00a30f5de32cf70af86737eb3013a7e82e14ce
Cr-Commit-Position: refs/heads/master@{#406588}