Remove InsecureContentInfobarDelegate, which has been broken for a while

Remove InsecureContentInfobarDelegate, which has been broken for a while
anyway and was only available behind a flag. Also remove said flag
(--no-displaying-insecure-content)

Originally it was used for all mixed content but a while ago it was
constrained to passive mixed content (i.e. display of insecure content).

BUG=628812
Committed: https://crrev.com/76fe1a62ccf75926531c6db9a434514846c20a63
Cr-Commit-Position: refs/heads/master@{#407833}

[Evan Stade, 2016-07-19 20:55:13]

estade@chromium.org changed reviewers:
+ felt@chromium.org, jochen@chromium.org

[Evan Stade, 2016-07-19 20:57:45]

p.s. there might be some more clean up that could be done in blink
(WebSettingsImpl::setAllowDisplayOfInsecureContent etc.) but I don't know if
that's still useful to other content clients, and it's getting pretty far from
my original goal which was to compile a list of existing UI surfaces/flush out
unused UI.

[Evan Stade, 2016-07-19 21:29:09]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 21:29:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[felt, 2016-07-19 21:46:59]

lgtm

https://codereview.chromium.org/2167513002/diff/1/chrome/browser/ssl/ssl_brow...
File chrome/browser/ssl/ssl_browser_tests.cc (left):

https://codereview.chromium.org/2167513002/diff/1/chrome/browser/ssl/ssl_brow...
chrome/browser/ssl/ssl_browser_tests.cc:2369:
IN_PROC_BROWSER_TEST_F(SSLUITestBlock, TestBlockDisplayingInsecureIframe) {
A note for posterity: TestBlockDisplayingInsecureIframe and
TestBlockRunningInsecureContent continue to pass because iframes and scripts are
active content. Active content is blocked by default and therefore is not
affected by removing the flag in this CL.

[felt, 2016-07-19 21:47:54]

On 2016/07/19 20:57:45, Evan Stade wrote:
> p.s. there might be some more clean up that could be done in blink
> (WebSettingsImpl::setAllowDisplayOfInsecureContent etc.) but I don't know if
> that's still useful to other content clients, and it's getting pretty far from
> my original goal which was to compile a list of existing UI surfaces/flush out
> unused UI.

Could you either keep the bug open, or start a new bug to clean up
setAllowDisplayOfInsecureContent? I just took a look and I don't think we need
it anymore, as long as the default is changed to allowing passive content.

[commit-bot: I haz the power, 2016-07-19 22:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 22:17:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2016-07-20 10:56:57]

lgtm

[Evan Stade, 2016-07-20 14:39:46]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 14:40:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 15:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 15:14:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2016-07-20 23:01:38]

I had to bring back SSLUITestBlock because its SetUpCommandLine override is
necessary (see comment in code).

[Evan Stade, 2016-07-20 23:01:42]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:40:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[felt, 2016-07-23 00:34:47]

still lgtm

[Evan Stade, 2016-07-25 22:16:11]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 22:16:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-07-25 23:19:45]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-07-25 23:19:49]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-07-25 23:19:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
felt@chromium.org
Link to the patchset: https://codereview.chromium.org/2167513002/#ps40001
(title: "fix AW?")

[commit-bot: I haz the power, 2016-07-25 23:20:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 23:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:27:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-07-26 00:24:46]

estade@chromium.org changed reviewers:
+ tsepez@chromium.org

[Evan Stade, 2016-07-26 00:24:46]

+tsepez for ipc message removal

[Tom Sepez, 2016-07-26 16:46:15]

LGTM.  Quite a bit of plumbing indeed.  Thanks.

[Evan Stade, 2016-07-26 17:02:54]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:03:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:07:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-26 17:11:20]

Description was changed from

==========
Remove InsecureContentInfobarDelegate, which has been broken for a while
anyway and was only available behind a flag. Also remove said flag
(--no-displaying-insecure-content)

Originally it was used for all mixed content but a while ago it was
constrained to passive mixed content (i.e. display of insecure content).

BUG=628812
==========

to

==========
Remove InsecureContentInfobarDelegate, which has been broken for a while
anyway and was only available behind a flag. Also remove said flag
(--no-displaying-insecure-content)

Originally it was used for all mixed content but a while ago it was
constrained to passive mixed content (i.e. display of insecure content).

BUG=628812

Committed: https://crrev.com/76fe1a62ccf75926531c6db9a434514846c20a63
Cr-Commit-Position: refs/heads/master@{#407833}
==========

[commit-bot: I haz the power, 2016-07-26 17:11:21]

Patchset 3 (id:??) landed as
https://crrev.com/76fe1a62ccf75926531c6db9a434514846c20a63
Cr-Commit-Position: refs/heads/master@{#407833}