Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2167503002: Stub in Mac viewer code. (Closed)

Created:
4 years, 5 months ago by jvanverth1
Modified:
4 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stub in Mac viewer code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2164683002 patch from issue 2164683002 at patchset 1 (http://crrev.com/2164683002#ps1) Committed: https://skia.googlesource.com/skia/+/a3f3caccdfa6e5e044cc1c76e256e55b8a6004ad

Patch Set 1 #

Patch Set 2 : Exclude Mac files from other Viewer builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -56 lines) Patch
M gyp/most.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/viewer.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + tools/viewer/sk_app/mac/GLWindowContext_mac.h View 2 chunks +9 lines, -6 lines 0 comments Download
A + tools/viewer/sk_app/mac/GLWindowContext_mac.cpp View 3 chunks +25 lines, -12 lines 0 comments Download
A tools/viewer/sk_app/mac/Window_mac.h View 1 chunk +67 lines, -0 lines 0 comments Download
A + tools/viewer/sk_app/mac/Window_mac.cpp View 6 chunks +20 lines, -22 lines 0 comments Download
A + tools/viewer/sk_app/mac/main_mac.cpp View 4 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jvanverth1
This should allow it to compile on the trybots.
4 years, 5 months ago (2016-07-19 19:57:34 UTC) #2
reed1
lgtm
4 years, 5 months ago (2016-07-19 20:00:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167503002/1
4 years, 5 months ago (2016-07-19 20:21:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/9826)
4 years, 5 months ago (2016-07-19 20:26:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167503002/20001
4 years, 5 months ago (2016-07-19 20:59:09 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 21:17:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a3f3caccdfa6e5e044cc1c76e256e55b8a6004ad

Powered by Google App Engine
This is Rietveld 408576698