Issue 21675003: CharacterData.substringData() arguments should be mandatory

Issue 21675003: CharacterData.substringData() arguments should be mandatory (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
haraken, tkent, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

CharacterData.substringData() arguments should be mandatory CharacterData.substringData() arguments should be mandatory as per the specification: http://dom.spec.whatwg.org/#dom-characterdata-substringdata Also, we should not throw if the second argument (count) is negative. This behavior is consistent with IE10 and Firefox. BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155516

Patch Set 1 #

Patch Set 2 : Rebaseline existing test #

Patch Set 3 : Rebaseline outdated DOM level1 conformance tests #

Patch Set 4 : Simplify link tag #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -13 lines)			Patch
M	LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative-expected.txt	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrreplacedatacountnegative-expected.txt	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	LayoutTests/dom/html/level1/core/hc_characterdataindexsizeerrsubstringcountnegative-expected.txt	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	LayoutTests/dom/xhtml/level1/core/hc_characterdataindexsizeerrdeletedatacountnegative-expected.txt	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/dom/xhtml/level1/core/hc_characterdataindexsizeerrreplacedatacountnegative-expected.txt	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/dom/xhtml/level1/core/hc_characterdataindexsizeerrsubstringcountnegative-expected.txt	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/characterdata-api-arguments.html	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/characterdata-api-arguments-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/CharacterData.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21675003/14001

7 years, 4 months ago (2013-08-05 05:42:10 UTC) #5

Message was sent while issue was closed.

Change committed as 155516

Expand Messages | Collapse Messages