Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2167493004: Make ChromeOSVersionInfo singleton leaky to avoid startup thread restriction DCHECK (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
danakj, Patrick Monette
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChromeOSVersionInfo singleton leaky to avoid startup thread restriction DCHECK It doesn't do any interesting work on shutdown. The check was added today with https://codereview.chromium.org/1904273002/ This is needed to run a target_os="chromeos" build on Linux. BUG=none TEST=none Committed: https://crrev.com/5aa2d8c58b4dbb74437652c32dcdfec5a323db44 Cr-Commit-Position: refs/heads/master@{#406395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/sys_info_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
James Cook
pmonette, PTAL
4 years, 5 months ago (2016-07-19 21:08:38 UTC) #2
Patrick Monette
LGTM
4 years, 5 months ago (2016-07-19 21:09:59 UTC) #4
James Cook
danakj, can I get OWNERS?
4 years, 5 months ago (2016-07-19 21:11:12 UTC) #7
danakj
LGTM
4 years, 5 months ago (2016-07-19 21:16:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167493004/1
4 years, 5 months ago (2016-07-19 21:17:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 22:11:43 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 22:13:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5aa2d8c58b4dbb74437652c32dcdfec5a323db44
Cr-Commit-Position: refs/heads/master@{#406395}

Powered by Google App Engine
This is Rietveld 408576698