Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2167493003: [ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@stub-cache-fix
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] [stubs] Don't use Code::flags in megamorphic stub cache hash computations. BUG=chromium:618701 Committed: https://crrev.com/8aeb7439c91eb769f752ce87f6fc286c30761580 Cr-Commit-Position: refs/heads/master@{#37946}

Patch Set 1 #

Patch Set 2 : Magic constants tweaking #

Patch Set 3 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -333 lines) Patch
M src/code-stub-assembler.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/code-stub-assembler.cc View 6 chunks +10 lines, -32 lines 0 comments Download
M src/code-stubs.h View 5 chunks +5 lines, -0 lines 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 1 2 4 chunks +7 lines, -23 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 1 2 4 chunks +7 lines, -17 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 1 2 7 chunks +6 lines, -23 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 1 2 4 chunks +7 lines, -18 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 2 4 chunks +7 lines, -18 lines 0 comments Download
M src/ic/ppc/stub-cache-ppc.cc View 1 2 4 chunks +7 lines, -23 lines 0 comments Download
M src/ic/s390/stub-cache-s390.cc View 1 2 4 chunks +7 lines, -21 lines 0 comments Download
M src/ic/stub-cache.h View 1 4 chunks +16 lines, -22 lines 0 comments Download
M src/ic/stub-cache.cc View 6 chunks +28 lines, -32 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 4 chunks +6 lines, -16 lines 0 comments Download
M src/ic/x87/stub-cache-x87.cc View 1 2 7 chunks +6 lines, -23 lines 0 comments Download
M src/type-info.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/type-info.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 7 chunks +13 lines, -45 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (21 generated)
Igor Sheludko
PTAL
4 years, 5 months ago (2016-07-20 11:32:23 UTC) #13
Jakob Kummerow
Awesome. LGTM!
4 years, 5 months ago (2016-07-20 12:25:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167493003/60001
4 years, 5 months ago (2016-07-21 12:55:51 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-21 12:57:34 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 12:58:17 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8aeb7439c91eb769f752ce87f6fc286c30761580
Cr-Commit-Position: refs/heads/master@{#37946}

Powered by Google App Engine
This is Rietveld 408576698