Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2167473004: Fix mac_views_browser compile after r406360 (MessageLoop::Run() protected on Mac) (Closed)

Created:
4 years, 5 months ago by tapted
Modified:
4 years, 5 months ago
Reviewers:
fdoray
CC:
chromium-reviews, tfarina, dcheng, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mac_views_browser compile after r406360 (MessageLoop::Run() protected on Mac) The compile step regressed in http://go/macviewsbuilder/builds/11862 r406360 made MessageLoop::Run() a protected method on Mac. tab_drag_controller_interactive_uitest.cc uses it, and this is built on that Mac bot. Replace MessageLoop::current()->Run() with RunLoop().Run(). BUG=616447 TBR=fdoray@chromium.org Committed: https://crrev.com/8170ad0608f90dbcc21a932e244470a0740e8c41 Cr-Commit-Position: refs/heads/master@{#406512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tapted
TBR to fix build breakage
4 years, 5 months ago (2016-07-20 06:33:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167473004/1
4 years, 5 months ago (2016-07-20 06:34:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 07:29:35 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8170ad0608f90dbcc21a932e244470a0740e8c41 Cr-Commit-Position: refs/heads/master@{#406512}
4 years, 5 months ago (2016-07-20 07:31:27 UTC) #11
fdoray
4 years, 5 months ago (2016-07-20 13:08:39 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698