Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/devtools/hosted_mode/request.js

Issue 2167413002: DevTools: implement proxy server for hosted mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 var http = require("http");
2 var https = require("https");
3 var parseUrl = require("url").parse;
4
5 function request(url)
6 {
7 return new Promise((resolve, reject) => {
8 var request;
9 var protocol = parseUrl(url).protocol;
10
11 if (protocol === "https:") {
lushnikov 2016/07/22 02:56:21 style: remove {}
chenwilliam 2016/07/22 17:35:25 Done.
12 request = https.get(url, handleResponse);
13 } else if (protocol === "http:") {
14 request = http.get(url, handleResponse);
15 } else {
16 reject(new Error(`Invalid protocol for url: ${url}`))
17 }
18
19 function handleResponse(response)
20 {
21 if (response.statusCode !== 200) {
22 reject(new Error(`Request error: + ${response.statusCode}`));
lushnikov 2016/07/22 02:56:21 you'd want to return here as well
chenwilliam 2016/07/22 17:35:25 Done.
23 }
24 var body = "";
25 response.on("data", chunk => body += chunk);
26 response.on("end", () => resolve(body));
27 }
28
29 request.on("error", (err) => reject(err));
lushnikov 2016/07/22 02:56:21 this will throw in case of rejection
30 });
31 }
32
33 module.exports = request;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698