Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2167383003: MD Downloads: simplify how we detect focus changes that close the "More actions..." menu (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@roll-polymer2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: simplify how we detect focus changes that close the "More actions..." menu R=michaelpg@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # crisper.js Committed: https://crrev.com/f6194e362e9dd34e86b415c2ba29a4582ceea3a4 Cr-Commit-Position: refs/heads/master@{#407701}

Patch Set 1 : . #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 1 chunk +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (15 generated)
Dan Beam
also not urgent
4 years, 5 months ago (2016-07-21 23:22:15 UTC) #3
michaelpg
lgtm. sucks that you have to handle menu button focus yourself :-\
4 years, 5 months ago (2016-07-22 05:24:50 UTC) #4
Dan Beam
On 2016/07/22 05:24:50, michaelpg wrote: > lgtm. sucks that you have to handle menu button ...
4 years, 5 months ago (2016-07-23 00:54:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167383003/40001
4 years, 4 months ago (2016-07-26 02:56:44 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-07-26 04:03:12 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 04:06:51 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6194e362e9dd34e86b415c2ba29a4582ceea3a4
Cr-Commit-Position: refs/heads/master@{#407701}

Powered by Google App Engine
This is Rietveld 408576698