Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2167383002: Fix skia build broken by commit c38cd6 (Closed)

Created:
4 years, 5 months ago by Wei Li
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix skia build broken by commit c38cd6 Add back one function which is only used by Skia code. And make a couple small fixes. Committed: https://pdfium.googlesource.com/pdfium/+/8f19e4bc617d19e871137be55a34992e421585ad

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M core/fxge/ge/fx_ge_device.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Wei Li
pls review, thanks
4 years, 5 months ago (2016-07-21 22:41:27 UTC) #5
Lei Zhang
https://codereview.chromium.org/2167383002/diff/1/core/fxge/include/fx_ge.h File core/fxge/include/fx_ge.h (right): https://codereview.chromium.org/2167383002/diff/1/core/fxge/include/fx_ge.h#newcode218 core/fxge/include/fx_ge.h:218: void Flush(); Combine with line 387? https://codereview.chromium.org/2167383002/diff/1/core/fxge/skia/fx_skia_device.cpp File core/fxge/skia/fx_skia_device.cpp ...
4 years, 5 months ago (2016-07-21 22:58:51 UTC) #8
Wei Li
ptal, thanks https://codereview.chromium.org/2167383002/diff/1/core/fxge/include/fx_ge.h File core/fxge/include/fx_ge.h (right): https://codereview.chromium.org/2167383002/diff/1/core/fxge/include/fx_ge.h#newcode218 core/fxge/include/fx_ge.h:218: void Flush(); On 2016/07/21 22:58:51, Lei Zhang ...
4 years, 5 months ago (2016-07-22 03:55:21 UTC) #9
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-22 06:26:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167383002/20001
4 years, 5 months ago (2016-07-22 06:26:31 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 06:26:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8f19e4bc617d19e871137be55a34992e4215...

Powered by Google App Engine
This is Rietveld 408576698