Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2167353002: GN: restore gn.py partly as fetch-gn (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: restore gn.py partly as fetch-gn Same as before, except it explicitly only fetches GN instead of acting like a proxy for it. I found myself always typing 'gn' anyway. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167353002 Committed: https://skia.googlesource.com/skia/+/6af0c958a0d024f65a9049f5b84793e03b781801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A bin/fetch-gn View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 5 months ago (2016-07-21 21:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167353002/1
4 years, 5 months ago (2016-07-21 21:00:35 UTC) #5
jcgregorio
lgtm
4 years, 5 months ago (2016-07-21 21:00:55 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 10:34:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6af0c958a0d024f65a9049f5b84793e03b781801

Powered by Google App Engine
This is Rietveld 408576698