Issue 2167343002: Remove EnableMessageBox() / IsMessageBoxEnabled()

Issue 2167343002: Remove EnableMessageBox() / IsMessageBoxEnabled() (Closed)

Created:
4 years, 5 months ago by Tom Sepez

Modified:
4 years, 5 months ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Remove EnableMessageBox() / IsMessageBoxEnabled() It's always enabled. Also inline FXJS_MsgBox since it only has one caller. Committed: https://pdfium.googlesource.com/pdfium/+/1d3348ce0092d6d2a40de5f8433c0d0c16a1e12e

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -35 lines)			Patch
M	fpdfsdk/javascript/JS_Object.cpp	View	3 chunks	+10 lines, -24 lines	0 comments	Download
M	fpdfsdk/javascript/JS_Runtime_Stub.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	fpdfsdk/javascript/cjs_context.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	fpdfsdk/javascript/cjs_context.cpp	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	fpdfsdk/javascript/ijs_context.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 10 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167343002/1

4 years, 5 months ago (2016-07-21 20:27:20 UTC) #8

commit-bot: I haz the power

4 years, 5 months ago (2016-07-21 20:29:59 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/1d3348ce0092d6d2a40de5f8433c0d0c16a1...