Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2167333002: Reland: H264 HW encode using MediaFoundation (Closed)

Created:
4 years, 5 months ago by emircan
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: H264 HW encode using MediaFoundation Got reverted due to breaking MSVC build: https://bugs.chromium.org/p/chromium/issues/detail?id=630335#c2 This CL moves GTEST_FAIL() lines so that they fail at the end of the function. Original description ---------------------------------------------- H264 HW encode using MediaFoundation This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common MediaFoundation classes under mf_helpers.*. Note that, this is the first CL and H264 codec is still behind a flag. Design Doc(with perf measurements): http://goo.gl/UCnwyA BUG=590060 TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and "--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264 Also, added WIN specific sections at vea_unittests. TBR=ananta@chromium.org,avi@chromium.org,grt@chromium.org,sandersd@chromium.org,wuchengli@chromium.org The incremented change is trivial. Committed: https://crrev.com/aa60bafce8cb29062030362aaa7c321350b67f84 Cr-Commit-Position: refs/heads/master@{#407049}

Patch Set 1 : Original patch. #

Patch Set 2 : Move GTEST_FAIL() lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+982 lines, -129 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/win/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A media/base/win/mf_helpers.h View 1 chunk +77 lines, -0 lines 0 comments Download
A media/base/win/mf_helpers.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M media/gpu/BUILD.gn View 3 chunks +7 lines, -2 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 6 chunks +3 lines, -101 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.cc View 3 chunks +19 lines, -0 lines 0 comments Download
A media/gpu/media_foundation_video_encode_accelerator_win.h View 1 chunk +147 lines, -0 lines 0 comments Download
A media/gpu/media_foundation_video_encode_accelerator_win.cc View 1 chunk +562 lines, -0 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 1 22 chunks +86 lines, -25 lines 0 comments Download
M media/media.gyp View 3 chunks +8 lines, -1 line 0 comments Download
M media/media_gpu.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
emircan
4 years, 5 months ago (2016-07-21 21:56:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167333002/20001
4 years, 5 months ago (2016-07-21 23:57:00 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 03:53:22 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/aa60bafce8cb29062030362aaa7c321350b67f84 Cr-Commit-Position: refs/heads/master@{#407049}
4 years, 5 months ago (2016-07-22 03:56:57 UTC) #17
emircan
4 years, 5 months ago (2016-07-22 05:00:48 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2170133003/ by emircan@chromium.org.

The reason for reverting is: Build errors on this bot:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2630/steps/co....

Powered by Google App Engine
This is Rietveld 408576698