Fix the positioning of backgrounds positioned right and bottom

Fix the positioning of backgrounds positioned right and bottom

A recent change unnecessarily pixel snapped the destination rect
for background image painting before computing values determined by
that rectangle. This caused situations where subsequent sub-pixel
snapping pushes right and bottom positioned 1-pixel images outside
the dest rect when it is intersected with the paint rect.

The fix is to revert the line that early-snaps the dest rect.

New test added to cover this case. One other test that had got slightly
worse with the previous change gets better again with this change.

R=pdr@chromium.org
BUG=629075
Committed: https://crrev.com/098ef3d2deef53dcd893961a87a0a96cd9bf276b
Cr-Commit-Position: refs/heads/master@{#406946}

[Stephen Chennney, 2016-07-21 19:28:03]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:28:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen Chennney, 2016-07-21 19:29:44]

schenney@chromium.org changed reviewers:
+ fmalita@chromium.org

[Stephen Chennney, 2016-07-21 19:29:45]

Fix for an unnecessary change from a prior patch. Not sure how that change made
it in, but reverting it fixes this issue without breaking the other tests.

[commit-bot: I haz the power, 2016-07-21 19:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:46:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[f(malita), 2016-07-21 19:48:18]

On 2016/07/21 19:29:45, Stephen Chennney wrote:
> Fix for an unnecessary change from a prior patch. Not sure how that change
made
> it in, but reverting it fixes this issue without breaking the other tests.

LGTM

[Stephen Chennney, 2016-07-21 21:02:51]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2016-07-21 21:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 21:21:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-21 21:23:46]

Description was changed from

==========
Fix the positioning of backgrounds positioned right and bottom

A recent change unnecessarily pixel snapped the destination rect
for background image painting before computing values determined by
that rectangle. This caused situations where subsequent sub-pixel
snapping pushes right and bottom positioned 1-pixel images outside
the dest rect when it is intersected with the paint rect.

The fix is to revert the line that early-snaps the dest rect.

New test added to cover this case. One other test that had got slightly
worse with the previous change gets better again with this change.

R=pdr@chromium.org
BUG=629075
==========

to

==========
Fix the positioning of backgrounds positioned right and bottom

A recent change unnecessarily pixel snapped the destination rect
for background image painting before computing values determined by
that rectangle. This caused situations where subsequent sub-pixel
snapping pushes right and bottom positioned 1-pixel images outside
the dest rect when it is intersected with the paint rect.

The fix is to revert the line that early-snaps the dest rect.

New test added to cover this case. One other test that had got slightly
worse with the previous change gets better again with this change.

R=pdr@chromium.org
BUG=629075

Committed: https://crrev.com/098ef3d2deef53dcd893961a87a0a96cd9bf276b
Cr-Commit-Position: refs/heads/master@{#406946}
==========

[commit-bot: I haz the power, 2016-07-21 21:23:49]

Patchset 1 (id:??) landed as
https://crrev.com/098ef3d2deef53dcd893961a87a0a96cd9bf276b
Cr-Commit-Position: refs/heads/master@{#406946}