Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2167303002: Reenable support for CHROMIUM_set_uniform_location (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
The bug referenced in the comment was fixed and this was reenabled. I disabled shortly ...
4 years, 5 months ago (2016-07-21 19:17:06 UTC) #4
robertphillips
lgtm
4 years, 5 months ago (2016-07-21 19:23:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167303002/1
4 years, 5 months ago (2016-07-21 19:26:12 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:49:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d7bae18c7beda8c3ae6fa95c9c8630f30403b9db

Powered by Google App Engine
This is Rietveld 408576698