src/s390/code-stubs-s390.cc - Issue 2167273003: PPC/s390: [arm] Fix infinite loop in Math.pow(2,2147483648).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/s390/code-stubs-s390.cc

Issue 2167273003: PPC/s390: [arm] Fix infinite loop in Math.pow(2,2147483648). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/s390/code-stubs-s390.cc

diff --git a/src/s390/code-stubs-s390.cc b/src/s390/code-stubs-s390.cc

index 77a11aeb31591e34cf67d0ecb441595e5366742f..75cb25114dfc1cebe3efae1835e7ba7b2ae60c0e 100644

--- a/src/s390/code-stubs-s390.cc

+++ b/src/s390/code-stubs-s390.cc

@@ -776,7 +776,8 @@ void MathPowStub::Generate(MacroAssembler* masm) {

__ beq(&no_carry, Label::kNear);

__ mdbr(double_result, double_scratch);

__ bind(&no_carry);

- __ ShiftRightArithP(scratch, scratch, Operand(1));

+ __ ShiftRightP(scratch, scratch, Operand(1));

+ __ LoadAndTestP(scratch, scratch);

__ beq(&loop_end, Label::kNear);

__ mdbr(double_scratch, double_scratch);

__ b(&while_true);

« no previous file with comments | « src/ppc/code-stubs-ppc.cc ('k') | no next file » | no next file with comments »