src/ppc/code-stubs-ppc.cc - Issue 2167273003: PPC/s390: [arm] Fix infinite loop in Math.pow(2,2147483648).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ppc/code-stubs-ppc.cc

Issue 2167273003: PPC/s390: [arm] Fix infinite loop in Math.pow(2,2147483648). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ppc/code-stubs-ppc.cc

diff --git a/src/ppc/code-stubs-ppc.cc b/src/ppc/code-stubs-ppc.cc

index a9b89b1ddbea4a3313922df037e07bbdbec3fae7..bb5d965c9a790cc5cc3271cbfc66536fe5dbffc5 100644

--- a/src/ppc/code-stubs-ppc.cc

+++ b/src/ppc/code-stubs-ppc.cc

@@ -805,7 +805,7 @@ void MathPowStub::Generate(MacroAssembler* masm) {

__ beq(&no_carry, cr0);

__ fmul(double_result, double_result, double_scratch);

__ bind(&no_carry);

- __ ShiftRightArithImm(scratch, scratch, 1, SetRC);

+ __ ShiftRightImm(scratch, scratch, Operand(1), SetRC);

__ beq(&loop_end, cr0);

__ fmul(double_scratch, double_scratch, double_scratch);

__ b(&while_true);

« no previous file with comments | « no previous file | src/s390/code-stubs-s390.cc » ('j') | no next file with comments »