Revert r170330 "DevTools: Start/Stop overview recording for available mode"

Source/devtools/front_end/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 214 matching lines @@
      * @return {!WebInspector.TimelineFrameModel}
      */
     _frameModel: function()
     {
         if (!this._lazyFrameModel)
             this._lazyFrameModel = new WebInspector.TimelineFrameModel(this._model);
         return this._lazyFrameModel;
     },
 
     /**
-     * @return {!WebInspector.TimelinePanel.Mode}
-     */
-    _availableModes: function()
-    {
-        if (this._modes)
-            return this._modes;
-
-        this._modes = {
-            Events: WebInspector.TimelinePanel.Mode.Events,
-            Frames: WebInspector.TimelinePanel.Mode.Frames,
-            Memory: WebInspector.TimelinePanel.Mode.Memory,
-        };
-
-        if (WebInspector.experimentsSettings.timelineFlameChart.isEnabled())
-            this._modes.FlameChart = WebInspector.TimelinePanel.Mode.FlameChart;
-
-        if (Capabilities.canProfilePower)
-            this._modes.Power = WebInspector.TimelinePanel.Mode.Power;
-
-        return this._modes;
-    },
-
-    /**
      * @return {!WebInspector.TimelineView}
      */
     _timelineView: function()
     {
         if (!this._lazyTimelineView)
             this._lazyTimelineView = new WebInspector.TimelineView(this, this._model);
         return this._lazyTimelineView;
     },
 
     /**
@@ skipping 42 matching lines @@
     {
         this._viewsMap = {};
 
         var topPaneSidebarElement = this._topPane.sidebarElement();
         topPaneSidebarElement.id = "timeline-overview-sidebar";
 
         var overviewTreeElement = topPaneSidebarElement.createChild("ol", "sidebar-tree vbox");
         var topPaneSidebarTree = new TreeOutline(overviewTreeElement);
 
         this._overviewItems = {};
-        for (var mode in this._availableModes()) {
+        for (var mode in WebInspector.TimelinePanel.Mode) {
+            if (mode === WebInspector.TimelinePanel.Mode.FlameChart && !WebInspector.experimentsSettings.timelineFlameChart.isEnabled() ||
+                mode === WebInspector.TimelinePanel.Mode.Power && !Capabilities.canProfilePower)
+                continue;
             this._overviewItems[mode] = new WebInspector.SidebarTreeElement("timeline-overview-sidebar-" + mode.toLowerCase(), WebInspector.UIString(mode));
             var item = this._overviewItems[mode];
             item.onselect = this._onModeChanged.bind(this, mode);
             topPaneSidebarTree.appendChild(item);
         }
     },
 
     _createStatusBarItems: function()
     {
         var panelStatusBarElement = this.element.createChild("div", "panel-status-bar");
@@ skipping 240 matching lines @@
         this._updateSelectionDetails();
     },
 
     /**
      * @param {boolean} userInitiated
      */
     _startRecording: function(userInitiated)
     {
         this._userInitiatedRecording = userInitiated;
         this._model.startRecording();
-        for (var mode in this._availableModes())
+        for (var mode in WebInspector.TimelinePanel.Mode)
             this._viewsForMode(mode).overviewView.timelineStarted();
 
         if (userInitiated)
             WebInspector.userMetrics.TimelineStarted.record();
     },
 
     _stopRecording: function()
     {
         this._userInitiatedRecording = false;
         this._model.stopRecording();
-        for (var mode in this._availableModes())
+        for (var mode in WebInspector.TimelinePanel.Mode)
             this._viewsForMode(mode).overviewView.timelineStopped();
     },
 
     /**
      * @return {boolean}
      */
     _toggleTimelineButtonClicked: function()
     {
         if (this._operationInProgress)
             return true;
@@ skipping 564 matching lines @@
      * @param {!WebInspector.TimelineModel.Record} record
      * @return {boolean}
      */
     accept: function(record)
     {
         return !this._hiddenRecords[record.type];
     },
 
     __proto__: WebInspector.TimelineModel.Filter.prototype
 }