Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2167193002: Revert of Remove DrawFace enum from GrPipelineBuilder (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Remove DrawFace enum from GrPipelineBuilder (patchset #2 id:20001 of https://codereview.chromium.org/2165283002/ ) Reason for revert: No Vulkan bot in CQ :( Original issue's description: > Remove DrawFace enum from GrPipelineBuilder > > This gets GrPipelineBuilder.h out of the headers > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165283002 > > Committed: https://skia.googlesource.com/skia/+/da152ebb032c61bb2561bbb3e9a78037ad174d34 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/5d1676c751040f4d9a6259720c15250f0c979874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -61 lines) Patch
M include/gpu/GrTypesPriv.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPathRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPipeline.h View 4 chunks +3 lines, -7 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 2 chunks +12 lines, -4 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/instanced/InstancedRendering.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/text/GrBatchFontCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkPipeline.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gpu/GrTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Remove DrawFace enum from GrPipelineBuilder
4 years, 5 months ago (2016-07-21 15:17:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167193002/1
4 years, 5 months ago (2016-07-21 15:17:57 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 15:18:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5d1676c751040f4d9a6259720c15250f0c979874

Powered by Google App Engine
This is Rietveld 408576698