Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2167183002: Minor change to Ganesh path renderers (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor change to Ganesh path renderers In large part this is an attempt to get non-substantive changes out of https://codereview.chromium.org/2092893003/ (Retract PipelineBuilder some more) All the other parameters extracted from DrawPathArgs are passed around by reference except for the userStencilSettings GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2167183002 Committed: https://skia.googlesource.com/skia/+/d2b6d6486ed9d00df779f6b337d756c9a818006f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M src/gpu/GrSWMaskHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
robertphillips
4 years, 5 months ago (2016-07-21 15:16:18 UTC) #5
bsalomon
lgtm
4 years, 5 months ago (2016-07-21 15:21:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167183002/1
4 years, 5 months ago (2016-07-21 15:54:15 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 15:55:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d2b6d6486ed9d00df779f6b337d756c9a818006f

Powered by Google App Engine
This is Rietveld 408576698