Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2167173002: Remove SkGrPixelRef (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -416 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 4 chunks +0 lines, -24 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
D src/gpu/SkGrPixelRef.h View 1 chunk +0 lines, -61 lines 0 comments Download
D src/gpu/SkGrPixelRef.cpp View 1 chunk +0 lines, -212 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
robertphillips
4 years, 5 months ago (2016-07-21 14:46:02 UTC) #4
reed1
WBLGTM world's biggest lgtm
4 years, 5 months ago (2016-07-21 14:48:41 UTC) #5
bsalomon
lgtm lgtM lgTm lGtm Lgtm lgTM lGTm LGtm LgtM LgTm lGtM LgTM lGTM LGTm LGtM ...
4 years, 5 months ago (2016-07-21 14:54:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167173002/1
4 years, 5 months ago (2016-07-21 16:34:13 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 16:35:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f292a0c862f1c120cade1e8ac0f1882844eb343a

Powered by Google App Engine
This is Rietveld 408576698