Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: content/browser/media/webrtc/webrtc_browsertest.cc

Issue 2167133002: Separates the WebRTC browser tests that deal with audio detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Typo DISABLE -> DISABLED Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/webrtc/webrtc_browsertest_audio.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/webrtc/webrtc_browsertest.cc
diff --git a/content/browser/media/webrtc/webrtc_browsertest.cc b/content/browser/media/webrtc/webrtc_browsertest.cc
index 7a9fc3d344ebb7b1fbc72adbea124cd8be7671fe..b40113c975b77f4f2644964c2518d102dfe18487 100644
--- a/content/browser/media/webrtc/webrtc_browsertest.cc
+++ b/content/browser/media/webrtc/webrtc_browsertest.cc
@@ -45,27 +45,6 @@ class MAYBE_WebRtcBrowserTest : public WebRtcContentBrowserTest {
void MakeTypicalPeerConnectionCall(const std::string& javascript) {
MakeTypicalCall(javascript, "/media/peerconnection-call.html");
}
-
- // Convenience method for making calls that detect if audio os playing (which
- // has some special prerequisites, such that there needs to be an audio output
- // device on the executing machine).
- void MakeAudioDetectingPeerConnectionCall(const std::string& javascript) {
- if (!media::AudioManager::Get()->HasAudioOutputDevices()) {
- // Bots with no output devices will force the audio code into a state
- // where it doesn't manage to set either the low or high latency path.
- // This test will compute useless values in that case, so skip running on
- // such bots (see crbug.com/326338).
- LOG(INFO) << "Missing output devices: skipping test...";
- return;
- }
-
- ASSERT_TRUE(base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kUseFakeDeviceForMediaStream))
- << "Must run with fake devices since the test will explicitly look "
- << "for the fake device signal.";
-
- MakeTypicalPeerConnectionCall(javascript);
- }
};
// These tests will make a complete PeerConnection-based call and verify that
@@ -142,13 +121,6 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
MakeTypicalPeerConnectionCall(kJavascript);
}
-// Causes asserts in libjingle: http://crbug.com/484826.
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- DISABLED_CanMakeVideoCallAndThenRenegotiateToAudio) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndRenegotiateToAudio({audio: true, video:true}, {audio: true});");
-}
-
// This test makes a call between pc1 and pc2 where a video only stream is sent
// from pc1 to pc2. The stream sent from pc1 to pc2 is cloned from the stream
// received on pc2 to test that cloning of remote video and audio tracks works
@@ -219,54 +191,6 @@ IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, AddTwoMediaStreamsToOnePC) {
MakeTypicalPeerConnectionCall("addTwoMediaStreamsToOneConnection();");
}
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EstablishAudioVideoCallAndEnsureAudioIsPlaying) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndEnsureAudioIsPlaying({audio:true, video:true});");
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EstablishAudioOnlyCallAndEnsureAudioIsPlaying) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndEnsureAudioIsPlaying({audio:true});");
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EstablishIsac16KCallAndEnsureAudioIsPlaying) {
- MakeAudioDetectingPeerConnectionCall(
- "callWithIsac16KAndEnsureAudioIsPlaying({audio:true});");
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EstablishAudioVideoCallAndVerifyRemoteMutingWorks) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndEnsureRemoteAudioTrackMutingWorks();");
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EstablishAudioVideoCallAndVerifyLocalMutingWorks) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndEnsureLocalAudioTrackMutingWorks();");
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EnsureLocalVideoMuteDoesntMuteAudio) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndEnsureLocalVideoMutingDoesntMuteAudio();");
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EnsureRemoteVideoMuteDoesntMuteAudio) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndEnsureRemoteVideoMutingDoesntMuteAudio();");
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest,
- EstablishAudioVideoCallAndVerifyUnmutingWorks) {
- MakeAudioDetectingPeerConnectionCall(
- "callAndEnsureAudioTrackUnmutingWorks();");
-}
-
IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcBrowserTest, CallAndVerifyVideoMutingWorks) {
MakeTypicalPeerConnectionCall("callAndEnsureVideoTrackMutingWorks();");
}
« no previous file with comments | « no previous file | content/browser/media/webrtc/webrtc_browsertest_audio.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698