Separates the WebRTC browser tests that deal with audio detection.

Separates the WebRTC browser tests that deal with audio detection.

This is to make peerconnection-call.html and webrtc_browsertest.cc
more readable

BUG=6135
Committed: https://crrev.com/d7c595ce0f4192a8a095131dc7a8d98b2a52b688
Cr-Commit-Position: refs/heads/master@{#407116}

[ehmaldonado_webrtc, 2016-07-21 13:56:07]

ehmaldonado@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org, phoglund@chromium.org

[phoglund_chromium, 2016-07-22 07:28:14]

Very nice, just a few comments.

https://codereview.chromium.org/2167133002/diff/40001/content/test/data/media...
File content/test/data/media/peerconnection-call-audio.html (right):

https://codereview.chromium.org/2167133002/diff/40001/content/test/data/media...
content/test/data/media/peerconnection-call-audio.html:19: var gTestWithoutMsid
= false;
This one is not used in this test; get rid of it. By the way, this might be true
for the peerconnection-call-data file as well.

https://codereview.chromium.org/2167133002/diff/40001/content/test/data/media...
content/test/data/media/peerconnection-call-audio.html:23: var gRemoteStreams =
{};
Nit: just one blank line

https://codereview.chromium.org/2167133002/diff/40001/content/test/data/media...
content/test/data/media/peerconnection-call-audio.html:220: <td><video
width="320" height="240" id="remote-view-1"
You don't need all of these video tags and canvases. As you can see above,
you're only using remote-view-1 and remote-view-2, so just keep those and their
canvases.

By the way, look over peerconnection-call-data as well and remove tags that are
not needed.

[ehmaldonado, 2016-07-22 08:19:34]

ptal

[phoglund_chromium, 2016-07-22 08:53:29]

https://codereview.chromium.org/2167133002/diff/60001/content/browser/media/w...
File content/browser/media/webrtc/webrtc_browsertest_audio.cc (right):

https://codereview.chromium.org/2167133002/diff/60001/content/browser/media/w...
content/browser/media/webrtc/webrtc_browsertest_audio.cc:67:
CanMakeVideoCallAndThenRenegotiateToAudio) {
So this test worked? In that case you should remove the comment above and close
the associated bug. Either way, don't do that in this CL, make a separate CL.

[ehmaldonado_chromium, 2016-07-22 08:59:10]

ehmaldonado@chromium.org changed reviewers:
+ ehmaldonado@chromium.org

[ehmaldonado_chromium, 2016-07-22 08:59:11]

https://codereview.chromium.org/2167133002/diff/60001/content/browser/media/w...
File content/browser/media/webrtc/webrtc_browsertest_audio.cc (right):

https://codereview.chromium.org/2167133002/diff/60001/content/browser/media/w...
content/browser/media/webrtc/webrtc_browsertest_audio.cc:67:
CanMakeVideoCallAndThenRenegotiateToAudio) {
On 2016/07/22 08:53:28, phoglund_chrome wrote:
> So this test worked? In that case you should remove the comment above and
close
> the associated bug. Either way, don't do that in this CL, make a separate CL.

Yes it worked.
Done.

[phoglund_chromium, 2016-07-22 09:01:00]

lgtm

[ehmaldonado_chromium, 2016-07-22 09:07:41]

The CQ bit was checked by ehmaldonado@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:54:24]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-22 09:56:22]

Description was changed from

==========
Separates the WebRTC browser tests that deal with audio detection.

This is to make peerconnection-call.html and webrtc_browsertest.cc
more readable

BUG=6135
==========

to

==========
Separates the WebRTC browser tests that deal with audio detection.

This is to make peerconnection-call.html and webrtc_browsertest.cc
more readable

BUG=6135

Committed: https://crrev.com/d7c595ce0f4192a8a095131dc7a8d98b2a52b688
Cr-Commit-Position: refs/heads/master@{#407116}
==========

[commit-bot: I haz the power, 2016-07-22 09:56:23]

Patchset 6 (id:??) landed as
https://crrev.com/d7c595ce0f4192a8a095131dc7a8d98b2a52b688
Cr-Commit-Position: refs/heads/master@{#407116}