Issue 216713002: TimelineFlameChart: fix for exception in highlightTimeRange which happens when entryIndex is incorr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216713002: TimelineFlameChart: fix for exception in highlightTimeRange which happens when entryIndex is incorr… (Closed)

Created:
6 years, 9 months ago by loislo

Modified:
6 years, 9 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

TimelineFlameChart: fix for exception in highlightTimeRange which happens when entryIndex is incorrect. It happens when newly recorded timeline has fewer elements than the old timeline. So we need to reset FlameChart when we start the new recording session. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170308

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/devtools/front_end/TimelineFlameChart.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

loislo

6 years, 9 months ago (2014-03-28 09:58:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r170308 (presubmit successful).

Expand Messages | Collapse Messages