Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2167113003: Reland of [Android] Enable platform mode for perf tests on Galaxy S5 (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of [Android] Enable platform mode for perf tests on Galaxy S5 (patchset #1 id:1 of https://codereview.chromium.org/2172463002/ ) Reason for revert: Fix landed. Original issue's description: > Revert of [Android] Enable platform mode for perf tests on Galaxy S5 (patchset #1 id:1 of https://codereview.chromium.org/2171463002/ ) > > Reason for revert: > https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20Perf%20%283%29/builds/2703 > > Original issue's description: > > [Android] Enable platform mode for perf tests on Galaxy S5 > > > > BUG=615157 > > > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/bf806e109ffa60364a3ec9983371555b69b662b4 > > TBR=dtu@chromium.org,stip@chromium.org,rnephew@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=615157 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/c24914b0f7d3df5373190d0b5950da82f08673b7 TBR=dtu@chromium.org,stip@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615157 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f91d5337a0d67c79c22ce9ebb71d00e19161e724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rnephew (Reviews Here)
Created Reland of [Android] Enable platform mode for perf tests on Galaxy S5
4 years, 5 months ago (2016-07-21 15:11:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167113003/1
4 years, 5 months ago (2016-07-21 15:11:11 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-21 15:11:16 UTC) #5
jbudorick
lgtm
4 years, 5 months ago (2016-07-21 15:14:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167113003/1
4 years, 5 months ago (2016-07-21 15:16:01 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 15:16:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/f91d5337a0d67c79c22c...

Powered by Google App Engine
This is Rietveld 408576698