Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 2167073002: Replace most callers of nextInputChar with peekWithoutReplacement in CSSTokenizer. (Closed)

Created:
4 years, 5 months ago by esprehn
Modified:
4 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace most callers of nextInputChar with peekWithoutReplacement in CSSTokenizer. This saves us a branch at each call site since we don't need to check for NUL characters. BUG=605792 Committed: https://crrev.com/a7b9e5829dda06696a44ad0447219676babc7ef6 Cr-Commit-Position: refs/heads/master@{#407044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp View 16 chunks +27 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
esprehn
4 years, 5 months ago (2016-07-21 07:31:44 UTC) #6
Timothy Loh
On 2016/07/21 07:31:44, esprehn wrote: lgtm
4 years, 5 months ago (2016-07-22 00:45:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167073002/1
4 years, 5 months ago (2016-07-22 00:58:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:47:44 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:51:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7b9e5829dda06696a44ad0447219676babc7ef6
Cr-Commit-Position: refs/heads/master@{#407044}

Powered by Google App Engine
This is Rietveld 408576698