Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: components/ntp_snippets/ntp_snippet.h

Issue 2167063003: Rename discard to dismiss for NTP snippets and content suggestions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bridgeumbiegen
Patch Set: Fix unit test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippet.h
diff --git a/components/ntp_snippets/ntp_snippet.h b/components/ntp_snippets/ntp_snippet.h
index 2d92bd31c85194a35b95d1c9cdd43d05abbb42f7..18b0729cc0bfd7b750410851a306602af30f877f 100644
--- a/components/ntp_snippets/ntp_snippet.h
+++ b/components/ntp_snippets/ntp_snippet.h
@@ -122,8 +122,8 @@ class NTPSnippet {
float score() const { return score_; }
void set_score(float score) { score_ = score; }
- bool is_discarded() const { return is_discarded_; }
- void set_discarded(bool discarded) { is_discarded_ = discarded; }
+ bool is_dismissed() const { return is_dismissed_; }
+ void set_dismissed(bool dismissed) { is_dismissed_ = dismissed; }
// Public for testing.
static base::Time TimeFromJsonString(const std::string& timestamp_str);
@@ -139,7 +139,7 @@ class NTPSnippet {
base::Time publish_date_;
base::Time expiry_date_;
float score_;
- bool is_discarded_;
+ bool is_dismissed_;
size_t best_source_index_;
« no previous file with comments | « components/ntp_snippets/content_suggestions_service_unittest.cc ('k') | components/ntp_snippets/ntp_snippet.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698