Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: runtime/observatory/lib/src/app/location_manager.dart

Issue 2167053002: Converted Observatory nav-notify element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fixed template ciclic references that were blocking initialization Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/app/application.dart ('k') | runtime/observatory/lib/src/app/notification.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/location_manager.dart
diff --git a/runtime/observatory/lib/src/app/location_manager.dart b/runtime/observatory/lib/src/app/location_manager.dart
index 577cb92101c87337cbe476abbe33c5d1d6c6dc25..64ea764f927c66b5893117aad31470ea112c7f8f 100644
--- a/runtime/observatory/lib/src/app/location_manager.dart
+++ b/runtime/observatory/lib/src/app/location_manager.dart
@@ -54,6 +54,11 @@ class LocationManager extends Observable {
/// Update the application location. After this function returns,
/// [uri] and [debugArguments] will be updated.
_updateApplicationLocation(String url) {
+ if (url == makeLink('/vm-connect')) {
+ // When we go to the vm-connect page, drop all notifications.
+ _app.notifications.deleteAll();
+ }
+
// Chop off leading '#'.
if (url.startsWith('#')) {
url = url.substring(1);
@@ -115,11 +120,6 @@ class LocationManager extends Observable {
url = makeLink('/vm-connect');
}
- if (url == makeLink('/vm-connect')) {
- // When we go to the vm-connect page, drop all notifications.
- _app.notifications.clear();
- }
-
if (addToBrowserHistory) {
_addToBrowserHistory(url);
}
« no previous file with comments | « runtime/observatory/lib/src/app/application.dart ('k') | runtime/observatory/lib/src/app/notification.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698