Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2167043002: MD Settings: ensure <a is="action-link"> have no :hover underline (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: ensure <a is="action-link"> have no :hover underline tl;dr - the style loading order matters, action_link.css must come before <style include="settings-shared">. R=hcarmona@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01 Cr-Commit-Position: refs/heads/master@{#406755}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 10 (5 generated)
Dan Beam
https://codereview.chromium.org/2167043002/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2167043002/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html#newcode54 chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:54: text-decoration: underline; i'm going to change this separately
4 years, 5 months ago (2016-07-21 01:59:59 UTC) #2
hcarmona
LGTM https://codereview.chromium.org/2167043002/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html File chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html (right): https://codereview.chromium.org/2167043002/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html#newcode54 chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:54: text-decoration: underline; On 2016/07/21 01:59:59, Dan Beam wrote: ...
4 years, 5 months ago (2016-07-21 02:10:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167043002/1
4 years, 5 months ago (2016-07-21 02:16:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 03:18:56 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:22:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ff90f4a2f6f30b5e01f9bef16cbe27efce16b01
Cr-Commit-Position: refs/heads/master@{#406755}

Powered by Google App Engine
This is Rietveld 408576698