Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2167033002: Update the MB builder mapping w/ a few changes. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw, smut
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the MB builder mapping w/ a few changes. A couple of builders have been removed, and one has been added but it doesn't do compiles. TBR=brettw@chromium.org BUG= Committed: https://crrev.com/cc19e4cf151fec79f7c7052598666de61b20b946 Cr-Commit-Position: refs/heads/master@{#406939}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +1 line, -3 lines 1 comment Download

Messages

Total messages: 15 (5 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-21 20:02:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167033002/1
4 years, 5 months ago (2016-07-21 20:02:51 UTC) #3
brettw
lgtm
4 years, 5 months ago (2016-07-21 20:03:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99871)
4 years, 5 months ago (2016-07-21 20:18:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167033002/1
4 years, 5 months ago (2016-07-21 20:38:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 21:13:21 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cc19e4cf151fec79f7c7052598666de61b20b946 Cr-Commit-Position: refs/heads/master@{#406939}
4 years, 5 months ago (2016-07-21 21:15:32 UTC) #11
smut
https://codereview.chromium.org/2167033002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (left): https://codereview.chromium.org/2167033002/diff/1/tools/mb/mb_config.pyl#oldcode791 tools/mb/mb_config.pyl:791: 'ios-simulator-cronet': 'ios_gyp', Er, why did this need to be ...
4 years, 5 months ago (2016-07-21 23:46:31 UTC) #13
Dirk Pranke
On 2016/07/21 23:46:31, smut wrote: > https://codereview.chromium.org/2167033002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (left): > > https://codereview.chromium.org/2167033002/diff/1/tools/mb/mb_config.pyl#oldcode791 > ...
4 years, 5 months ago (2016-07-22 00:13:38 UTC) #14
Dirk Pranke
4 years, 5 months ago (2016-07-22 00:14:16 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2169233002/ by dpranke@chromium.org.

The reason for reverting is: restore cronet entry..

Powered by Google App Engine
This is Rietveld 408576698