Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 216703004: remove SK_SUPPORT_LEGACY_GETCLIPTYPE (Closed)

Created:
6 years, 9 months ago by reed1
Modified:
6 years, 8 months ago
Reviewers:
reed2, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove SK_SUPPORT_LEGACY_GETCLIPTYPE after this lands and sticks, we can remove the assocated code from skia BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
assuming https://codereview.chromium.org/216883007/ lands, we can land this CL. Leaving that to you (next week) when ...
6 years, 9 months ago (2014-03-28 20:33:31 UTC) #1
reed2
The CQ bit was checked by reed@chromium.org
6 years, 9 months ago (2014-03-29 04:18:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/216703004/1
6 years, 9 months ago (2014-03-29 04:18:16 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 04:18:16 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-29 04:18:17 UTC) #5
reed1
ping
6 years, 8 months ago (2014-04-07 14:46:05 UTC) #6
robertphillips
lgtm
6 years, 8 months ago (2014-04-07 14:48:21 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 8 months ago (2014-04-07 14:52:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/216703004/1
6 years, 8 months ago (2014-04-07 14:52:14 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 15:17:39 UTC) #10
Message was sent while issue was closed.
Change committed as 14074

Powered by Google App Engine
This is Rietveld 408576698