Issue 216703003: Docs: Memoize the FeaturesBundles that are created by AvailabilityFinder to

Issue 216703003: Docs: Memoize the FeaturesBundles that are created by AvailabilityFinder to (Closed)

Created:
6 years, 9 months ago by not at google - send to devlin

Modified:
6 years, 9 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Docs: Memoize the FeaturesBundles that are created by AvailabilityFinder to maintain their caches. r259958 altered the way the feature data was populated and caused a big regression. This fixes it. R=rockot@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260232

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -5 lines)			Patch
M	chrome/common/extensions/docs/server2/app.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/availability_finder.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/cron.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/features_bundle.py	View	2 chunks	+6 lines, -3 lines	1 comment	Download
M	chrome/common/extensions/docs/server2/file_system.py	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

https://codereview.chromium.org/216703003/diff/1/chrome/common/extensions/docs/server2/features_bundle.py File chrome/common/extensions/docs/server2/features_bundle.py (right): https://codereview.chromium.org/216703003/diff/1/chrome/common/extensions/docs/server2/features_bundle.py#newcode45 chrome/common/extensions/docs/server2/features_bundle.py:45: populate = SingleFile(populate) and this is a minor optimisation ...

6 years, 9 months ago (2014-03-28 17:20:36 UTC) #1

not at google - send to devlin

The CQ bit was checked by kalman@chromium.org

6 years, 9 months ago (2014-03-28 18:30:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/216703003/1

6 years, 9 months ago (2014-03-28 18:33:12 UTC) #4

Message was sent while issue was closed.

Change committed as 260232

Expand Messages | Collapse Messages