Issue 216703002: Move the SigninProcess APIs from SigninManager to ChromeSigninClient.

Issue 216703002: Move the SigninProcess APIs from SigninManager to ChromeSigninClient. (Closed)

Created:
6 years, 9 months ago by blundell

Modified:
6 years, 9 months ago

Reviewers:
droger, Nico, Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, tfarina, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, haitaol+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered, maniscalco+watch_chromium.org, Roger Tawa OOO till Jul 10th, guohui

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move the SigninProcess APIs from SigninManager to ChromeSigninClient. These APIs are //chrome-specific, and rely on no other state from SigninManager. As these APIs are per-Profile, ChromeSigninClient is an appropriate place for them to live. BUG=334205 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260163

Patch Set 1 #

Patch Set 2 : Comment about bug #

Patch Set 3 : Remove cruft #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -111 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View		4 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/browser_permissions_policy_delegate.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/signin/chrome_signin_client.h	View	1 2	3 chunks	+28 lines, -1 line	0 comments	Download
M	chrome/browser/signin/chrome_signin_client.cc	View	1 2	3 chunks	+48 lines, -2 lines	0 comments	Download
M	chrome/browser/signin/signin_browsertest.cc	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/signin/signin_manager.h	View		5 chunks	+1 line, -26 lines	0 comments	Download
M	chrome/browser/signin/signin_manager.cc	View	1 2	5 chunks	+0 lines, -47 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper_unittest.cc	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

blundell

droger: For review. rogerta, guohi: FYI. SigninManager componentization would shortly become blocked on this issue, ...

6 years, 9 months ago (2014-03-28 09:43:17 UTC) #1

blundell

TBR=thakis for //chrome changes outside of //chrome/browser/signin

6 years, 9 months ago (2014-03-28 14:18:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/216703002/30001

6 years, 9 months ago (2014-03-28 14:21:11 UTC) #5

Message was sent while issue was closed.

Change committed as 260163

Expand Messages | Collapse Messages