Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2167003004: Re-enable CopyTreeWorkItemTest.NewNameAndCopyTest on DrMemory. (Closed)

Created:
4 years, 5 months ago by grt (UTC plus 2)
Modified:
4 years, 5 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable CopyTreeWorkItemTest.NewNameAndCopyTest on DrMemory. The test has somewhat better logging than before (r359674), so maybe we'll have some visibility into why the move fails. BUG=460584 R=pmonette@chromium.org Committed: https://crrev.com/58d88c8dcbe07d1f10b3ec6cca40e24dbbe48102 Cr-Commit-Position: refs/heads/master@{#406862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
D tools/valgrind/gtest_exclude/installer_util_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
grt (UTC plus 2)
PTAL. Please check the CQ box if it looks good to you, thanks.
4 years, 5 months ago (2016-07-21 13:33:05 UTC) #3
Patrick Monette
lgtm
4 years, 5 months ago (2016-07-21 15:40:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167003004/1
4 years, 5 months ago (2016-07-21 15:41:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 15:44:49 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 15:45:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58d88c8dcbe07d1f10b3ec6cca40e24dbbe48102
Cr-Commit-Position: refs/heads/master@{#406862}

Powered by Google App Engine
This is Rietveld 408576698