Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2166993002: Roll buildtools 55638fe5c3..60f7f9a8b4 (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 55638fe5c3..60f7f9a8b4 In order to roll GN af92718f55..1f41736051 (r405547:r406705) and pick up the following changes: 267b1de Make `gn refs` handle files in data directories properly. 5fc3faf Add TaskPriority as a parameter to SequencedWorkerPool in preparation for TaskScheduler experiment. aca0875 Make `gn refs` look at script files. 05316e0 Re-land r406064 "[GN] Add JSON project writer". 5a1b4b1 Revert of [GN] Add JSON project writer (patchset #11 id:200001 of https://codereview.chromium.org/2064533002/ ) d2edeb9 [GN] Add JSON project writer f0544fc Remove calls to MessageLoop::current() in tools. d93e5cf Document GN invoker and target name variables. TBR=dpranke@chromium.org Committed: https://crrev.com/d8a18dc3820a4d54d8fc9ad8667d242798f10d33 Cr-Commit-Position: refs/heads/master@{#406727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
brettw
4 years, 5 months ago (2016-07-20 23:30:59 UTC) #1
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-20 23:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166993002/1
4 years, 5 months ago (2016-07-20 23:31:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 00:30:48 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d8a18dc3820a4d54d8fc9ad8667d242798f10d33 Cr-Commit-Position: refs/heads/master@{#406727}
4 years, 5 months ago (2016-07-21 00:32:33 UTC) #7
msramek
4 years, 5 months ago (2016-07-22 09:29:52 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2171273002/ by msramek@chromium.org.

The reason for reverting is: Speculative revert - this probably broke the
official build - see crbug.com/630514 for more details. Will reland if the
suspicion was wrong..

Powered by Google App Engine
This is Rietveld 408576698