cc: Release pending overlay resources on swap-ack.

cc: Release pending overlay resources on swap-ack.

In case a gpu query is not required to check if overlay
resources have been released, we can release overlay
resources used by the previous frame on swap-ack instead
of waiting until the next swap buffers call.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c0d2c9e1c54533a7ec01180a9144e6708362ee66
Cr-Commit-Position: refs/heads/master@{#406732}

[Daniele Castagna, 2016-07-20 20:35:54]

Description was changed from

==========
cc: Release pending overlay resources on swap ack.

BUG=b/29430506
==========

to

==========
cc: Release pending overlay resources on swap ack.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2016-07-20 20:37:27]

Description was changed from

==========
cc: Release pending overlay resources on swap ack.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Release pending overlay resources on swap-ack.

In case a gpu query is not required to check if overlay
resources have been released, we can release overlay
resources used by the previous frame on swap-ack instead
of waiting until the next swap buffers call.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2016-07-20 20:37:34]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 20:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-07-20 21:02:06]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[Daniele Castagna, 2016-07-20 21:06:21]

dcastagna@chromium.org changed reviewers:
+ ccameron@chromium.org

[reveman, 2016-07-20 21:07:21]

reveman@chromium.org changed reviewers:
- ccameron@chromium.org

[reveman, 2016-07-20 21:07:22]

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2769: // Once a resouce has been swap-ACKed, send a
query to the GPU process to
nit: s/resouce/resource/

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2792: DCHECK_EQ(2U,
swapping_overlay_resources_.size());
nit: 2u

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2793: swapping_overlay_resources_.pop_front();
I think a comment here explaining why this is correct would be useful.

[commit-bot: I haz the power, 2016-07-20 21:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:16:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-07-20 21:22:23]

ccameron@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2016-07-20 21:22:24]

lg w/fixes

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2793: swapping_overlay_resources_.pop_front();
On 2016/07/20 21:07:21, reveman wrote:
> I think a comment here explaining why this is correct would be useful.

+1

[Daniele Castagna, 2016-07-20 23:02:29]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:03:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-07-20 23:03:58]

PTAL.

ResourcesExportedAndReturnedWithDelay had to be changed slightly.

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2769: // Once a resouce has been swap-ACKed, send a
query to the GPU process to
On 2016/07/20 at 21:07:22, reveman wrote:
> nit: s/resouce/resource/

Done.

https://codereview.chromium.org/2166973002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2792: DCHECK_EQ(2U,
swapping_overlay_resources_.size());
On 2016/07/20 at 21:07:22, reveman wrote:
> nit: 2u

I used the capital U to stay consistent with overlay_unittests.cc

[reveman, 2016-07-20 23:31:44]

lgtm

[commit-bot: I haz the power, 2016-07-20 23:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:42:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-07-21 00:09:51]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:10:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 00:48:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 00:49:46]

Description was changed from

==========
cc: Release pending overlay resources on swap-ack.

In case a gpu query is not required to check if overlay
resources have been released, we can release overlay
resources used by the previous frame on swap-ack instead
of waiting until the next swap buffers call.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Release pending overlay resources on swap-ack.

In case a gpu query is not required to check if overlay
resources have been released, we can release overlay
resources used by the previous frame on swap-ack instead
of waiting until the next swap buffers call.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c0d2c9e1c54533a7ec01180a9144e6708362ee66
Cr-Commit-Position: refs/heads/master@{#406732}
==========

[commit-bot: I haz the power, 2016-07-21 00:49:47]

Patchset 2 (id:??) landed as
https://crrev.com/c0d2c9e1c54533a7ec01180a9144e6708362ee66
Cr-Commit-Position: refs/heads/master@{#406732}