Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 2166963004: [runtime] %TransitionElementsKind works for any kind of JSObject. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] %TransitionElementsKind works for any kind of JSObject. The optimizing compilers actually invoke %TransitionElementsKind for any kind of JSObject, the only relevant thing is the elements kind. The runtime function was however checking for JSArray unnecessarily. This only worked by coincindence in Crankshaft because the stub would normally not call into the runtime fallback. R=jarin@chromium.org BUG=chromium:629823 Committed: https://crrev.com/f793cb1fc36f7ab0929b476e2ca66f2c176376b1 Cr-Commit-Position: refs/heads/master@{#37919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/runtime/runtime-array.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-629823.js View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-21 07:00:02 UTC) #1
Jarin
lgtm.
4 years, 5 months ago (2016-07-21 07:01:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166963004/1
4 years, 5 months ago (2016-07-21 07:01:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 07:22:59 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 07:24:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f793cb1fc36f7ab0929b476e2ca66f2c176376b1
Cr-Commit-Position: refs/heads/master@{#37919}

Powered by Google App Engine
This is Rietveld 408576698