Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2166953006: Eliminate FrameMojoShell. (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate FrameMojoShell. R=rockot@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/dd157e1ae8d937ab67ad8550f83b53bfc93947cc Cr-Commit-Position: refs/heads/master@{#407010}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -302 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D content/browser/frame_host/frame_mojo_shell.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/browser/frame_host/frame_mojo_shell.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 4 5 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 5 6 7 8 4 chunks +35 lines, -6 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +0 lines, -26 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 2 chunks +0 lines, -77 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_interface_provider.h View 1 2 3 4 2 chunks +7 lines, -8 lines 0 comments Download
M content/renderer/media/media_interface_provider.cc View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 chunks +2 lines, -20 lines 0 comments Download
M services/shell/public/cpp/connection.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (22 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-07-21 20:59:10 UTC) #6
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2166953006/diff/110001/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (right): https://codereview.chromium.org/2166953006/diff/110001/content/browser/frame_host/render_frame_host_impl.cc#newcode2108 content/browser/frame_host/render_frame_host_impl.cc:2108: base::Unretained(GetProcess()->GetBrowserContext()), nit: You don't need base::Unretained when not ...
4 years, 5 months ago (2016-07-21 22:34:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166953006/130001
4 years, 5 months ago (2016-07-21 22:39:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166953006/150001
4 years, 5 months ago (2016-07-21 22:56:30 UTC) #25
commit-bot: I haz the power
Committed patchset #9 (id:150001)
4 years, 5 months ago (2016-07-22 03:16:13 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:17:44 UTC) #28
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/dd157e1ae8d937ab67ad8550f83b53bfc93947cc
Cr-Commit-Position: refs/heads/master@{#407010}

Powered by Google App Engine
This is Rietveld 408576698