Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2166953005: Remove the use of handler array in CPDFSDK_AnnotHandlerMgr (Closed)

Created:
4 years, 5 months ago by Wei Li
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove the use of handler array in CPDFSDK_AnnotHandlerMgr Use map to store and manage the handlers directly instead of needing an extra array. Committed: https://pdfium.googlesource.com/pdfium/+/9ca2b09126b80c03655f0eee1f02e1b2d0a18230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M fpdfsdk/fsdk_annothandler.cpp View 2 chunks +3 lines, -17 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Wei Li
pls review, thanks
4 years, 5 months ago (2016-07-21 19:07:28 UTC) #2
Lei Zhang
4 years, 5 months ago (2016-07-21 19:20:52 UTC) #4
dsinclair
lgtm
4 years, 5 months ago (2016-07-21 19:24:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166953005/1
4 years, 5 months ago (2016-07-21 19:24:28 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:26:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/9ca2b09126b80c03655f0eee1f02e1b2d0a1...

Powered by Google App Engine
This is Rietveld 408576698