Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2166953002:
Bug Fix: Tab Capture Mouse Pointer Off On Mac (Closed)
|
Created:
4 years, 5 months ago by qiangchen Modified:
4 years, 5 months ago CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBug Fix: Tab Capture Mouse Pointer Off On Mac
The cursor renderer on Mac, takes the chrome window based coordinate
as web contents based coordinate.
This CL fixes that bug.
BUG=625237
Committed: https://crrev.com/f5a740f351bda75b14e6631baf00a0764f86ea15
Cr-Commit-Position: refs/heads/master@{#407637}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac BUG= ========== to ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac The cursor renderer on Mac, take the chrome window based coordinate as web contents based coordinate. This CL fixes that bug. BUG=625237 ==========
qiangchen@chromium.org changed reviewers: + isheriff@chromium.org, miu@chromium.org
Description was changed from ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac The cursor renderer on Mac, take the chrome window based coordinate as web contents based coordinate. This CL fixes that bug. BUG=625237 ========== to ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac The cursor renderer on Mac, takes the chrome window based coordinate as web contents based coordinate. This CL fixes that bug. BUG=625237 ==========
A quick fix for mouse cursor pointer off bug. PTAL.
lgtm
miu@: Can you sign off this CL? isheriff@ is not an owner.
The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
qiangchen@chromium.org changed reviewers: + avi@chromium.org
Hi, avi@: Can you take a quick look at this CL? Essentially one line change, a quick fix for Mac cursor renderer. Qiang
lgtm
The CQ bit was checked by qiangchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac The cursor renderer on Mac, takes the chrome window based coordinate as web contents based coordinate. This CL fixes that bug. BUG=625237 ========== to ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac The cursor renderer on Mac, takes the chrome window based coordinate as web contents based coordinate. This CL fixes that bug. BUG=625237 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac The cursor renderer on Mac, takes the chrome window based coordinate as web contents based coordinate. This CL fixes that bug. BUG=625237 ========== to ========== Bug Fix: Tab Capture Mouse Pointer Off On Mac The cursor renderer on Mac, takes the chrome window based coordinate as web contents based coordinate. This CL fixes that bug. BUG=625237 Committed: https://crrev.com/f5a740f351bda75b14e6631baf00a0764f86ea15 Cr-Commit-Position: refs/heads/master@{#407637} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f5a740f351bda75b14e6631baf00a0764f86ea15 Cr-Commit-Position: refs/heads/master@{#407637}
Message was sent while issue was closed.
lgtm Looks reasonable. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
