Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 216693007: Adds timestamp to the log messages from Chrome in the webrtc native log. (Closed)

Created:
6 years, 9 months ago by jiayl
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, Henrik Grunell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds timestamp to the log messages from Chrome in the webrtc native log. BUG=357703 TESTED=try jobs passed NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260319

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M content/renderer/media/webrtc_logging.cc View 2 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jiayl
PTAL
6 years, 9 months ago (2014-03-28 19:47:25 UTC) #1
vrk (LEFT CHROMIUM)
lgtm Of course it's not ideal, but worth committing now since it's definitely better than ...
6 years, 8 months ago (2014-03-28 21:34:24 UTC) #2
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 8 months ago (2014-03-28 21:36:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/216693007/20001
6 years, 8 months ago (2014-03-28 21:38:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 00:22:17 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-29 00:22:18 UTC) #6
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 8 months ago (2014-03-29 00:24:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/216693007/20001
6 years, 8 months ago (2014-03-29 00:28:09 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 00:30:51 UTC) #9
Message was sent while issue was closed.
Change committed as 260319

Powered by Google App Engine
This is Rietveld 408576698