Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 216693005: Fix memory overwrite when sending error code on socket (Closed)

Created:
6 years, 8 months ago by psj
Modified:
6 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix memory overwrite when sending error code on socket BUG=357593 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/host/gnubby_socket.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
psj
6 years, 8 months ago (2014-03-28 17:17:51 UTC) #1
Sergey Ulanov
lgtm
6 years, 8 months ago (2014-03-28 19:24:10 UTC) #2
psj
The CQ bit was checked by psj@chromium.org
6 years, 8 months ago (2014-03-28 19:57:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/psj@chromium.org/216693005/1
6 years, 8 months ago (2014-03-28 19:57:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 21:47:06 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-28 21:47:06 UTC) #6
psj
The CQ bit was checked by psj@chromium.org
6 years, 8 months ago (2014-03-28 21:48:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/psj@chromium.org/216693005/1
6 years, 8 months ago (2014-03-28 21:53:46 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 23:44:57 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-28 23:44:58 UTC) #10
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-03-28 23:46:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/psj@chromium.org/216693005/1
6 years, 8 months ago (2014-03-28 23:51:44 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 01:26:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 01:26:30 UTC) #14
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 8 months ago (2014-03-29 01:32:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/psj@chromium.org/216693005/1
6 years, 8 months ago (2014-03-29 01:32:26 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 01:34:54 UTC) #17
Message was sent while issue was closed.
Change committed as 260335

Powered by Google App Engine
This is Rietveld 408576698