skia/skia_test_expectations.txt - Issue 216693004: Remove skia test expectations for now-passing tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: skia/skia_test_expectations.txt

Issue 216693004: Remove skia test expectations for now-passing tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # TEMPORARY overrides of	1 # TEMPORARY overrides of

2 # src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt	2 # src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt

3 # that are associated with changes to the Skia code.	3 # that are associated with changes to the Skia code.

4 #	4 #

5 # GUIDELINES:	5 # GUIDELINES:

6 # - This file should be empty most of the time.	6 # - This file should be empty most of the time.

7 # - Expectations should only be added TEMPORARILY, as a step towards	7 # - Expectations should only be added TEMPORARILY, as a step towards

8 # rebaselining layout test results. If any one expectation remains in here	8 # rebaselining layout test results. If any one expectation remains in here

9 # for more than a week or two, then we are probably doing something wrong.	9 # for more than a week or two, then we are probably doing something wrong.

10 # - Expectations from this file should NOT be rolled into any other	10 # - Expectations from this file should NOT be rolled into any other

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 #	44 #

45 # 6. Make sure to rebaseline the layout tests as soon as possible! The longer	45 # 6. Make sure to rebaseline the layout tests as soon as possible! The longer

46 # we leave overrides in this file, the harder it will be to rebaseline those	46 # we leave overrides in this file, the harder it will be to rebaseline those

47 # tests (because other rendering changes might creep in).	47 # tests (because other rendering changes might creep in).

48 #	48 #

49 # START OVERRIDES HERE	49 # START OVERRIDES HERE

50	50

51 # The Skia roll to r13482 altered the following layout tests:	51 # The Skia roll to r13482 altered the following layout tests:

52 crbug.com/344497 [ Win ] virtual/deferred/fast/images/webp-color-profile-lossy.h tml [ ImageOnlyFailure ]	52 crbug.com/344497 [ Win ] virtual/deferred/fast/images/webp-color-profile-lossy.h tml [ ImageOnlyFailure ]

53	53

54 # Skia 13798 change to spot lights

55 crbug.com/352628 css3/filters/effect-combined-hw.html [ ImageOnlyFailure ]

56 crbug.com/352628 css3/filters/effect-reference-ordering-hw.html [ ImageOnlyFailu re ]

57

58 # Roll to 13948 caused negligible changes to transformations to be rebaselined ( fmalita):	54 # Roll to 13948 caused negligible changes to transformations to be rebaselined ( fmalita):

59 crbug.com/356644 fast/canvas/image-pattern-rotate.html [ ImageOnlyFailure ]	55 crbug.com/356644 fast/canvas/image-pattern-rotate.html [ ImageOnlyFailure ]

60 crbug.com/356644 virtual/gpu/fast/canvas/image-object-in-canvas.html [ ImageOnly Failure ]	56 crbug.com/356644 virtual/gpu/fast/canvas/image-object-in-canvas.html [ ImageOnly Failure ]

61	57

62 # END OVERRIDES HERE (this line ensures that the file is newline-terminated)	58 # END OVERRIDES HERE (this line ensures that the file is newline-terminated)

OLD	NEW