third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2166923004: Fix Ruby visual rects in flipped blocks writing mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2166923004: Fix Ruby visual rects in flipped blocks writing mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Back to patch 1 with updated test and comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/ruby-flipped-blocks-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index e59ec0a172a46cd5934620fc9ed8dc86ec46f8cd..277b0aea0ad7367fdd1d0dc76bd4a1e1978fd3cd 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2094,6 +2094,10 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances

// coordinate space to the parent space, then back to <tr> / <td>.

if (tableRowContainer)

topLeft.moveBy(-tableRowContainer->topLeftLocation(toLayoutBox(container)));

+ } else if (container->isRuby()) {

+ // TODO(wkorman): Generalize Ruby specialization and/or document more clearly.

+ // See the accompanying specialization in LayoutInline::mapToVisualRectInAncestorSpace.

+ topLeft.moveBy(topLeftLocation());

} else {

topLeft.moveBy(location());

}