Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 2166923004: Fix Ruby visual rects in flipped blocks writing mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back to patch 1 with updated test and comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 1084 matching lines...) Expand 10 before | Expand all | Expand 10 after
1095 // is translated, but the layout box isn't, so we need to do this to get the 1095 // is translated, but the layout box isn't, so we need to do this to get the
1096 // right dirty rect. Since this is called from LayoutObject::setStyle, t he relative position 1096 // right dirty rect. Since this is called from LayoutObject::setStyle, t he relative position
1097 // flag on the LayoutObject has been cleared, so use the one on the styl e(). 1097 // flag on the LayoutObject has been cleared, so use the one on the styl e().
1098 rect.move(layer()->offsetForInFlowPosition()); 1098 rect.move(layer()->offsetForInFlowPosition());
1099 } 1099 }
1100 1100
1101 LayoutBox* containerBox = container->isBox() ? toLayoutBox(container) : null ptr; 1101 LayoutBox* containerBox = container->isBox() ? toLayoutBox(container) : null ptr;
1102 if (containerBox && !containerBox->mapScrollingContentsRectToBoxSpace(rect, container == ancestor ? ApplyNonScrollOverflowClip : ApplyOverflowClip, visualRe ctFlags)) 1102 if (containerBox && !containerBox->mapScrollingContentsRectToBoxSpace(rect, container == ancestor ? ApplyNonScrollOverflowClip : ApplyOverflowClip, visualRe ctFlags))
1103 return false; 1103 return false;
1104 1104
1105 if (containerBox) 1105 // TODO(wkorman): Generalize Ruby specialization and/or document more clearl y.
1106 if (containerBox && !isRuby())
1106 containerBox->flipForWritingMode(rect); 1107 containerBox->flipForWritingMode(rect);
1107 return container->mapToVisualRectInAncestorSpace(ancestor, rect, visualRectF lags); 1108 return container->mapToVisualRectInAncestorSpace(ancestor, rect, visualRectF lags);
1108 } 1109 }
1109 1110
1110 LayoutSize LayoutInline::offsetFromContainer(const LayoutObject* container) cons t 1111 LayoutSize LayoutInline::offsetFromContainer(const LayoutObject* container) cons t
1111 { 1112 {
1112 ASSERT(container == this->container()); 1113 ASSERT(container == this->container());
1113 1114
1114 LayoutSize offset; 1115 LayoutSize offset;
1115 if (isInFlowPositioned()) 1116 if (isInFlowPositioned())
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
1358 1359
1359 void LayoutInline::invalidateDisplayItemClients(PaintInvalidationReason invalida tionReason) const 1360 void LayoutInline::invalidateDisplayItemClients(PaintInvalidationReason invalida tionReason) const
1360 { 1361 {
1361 LayoutBoxModelObject::invalidateDisplayItemClients(invalidationReason); 1362 LayoutBoxModelObject::invalidateDisplayItemClients(invalidationReason);
1362 1363
1363 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox()) 1364 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())
1364 invalidateDisplayItemClient(*box, invalidationReason); 1365 invalidateDisplayItemClient(*box, invalidationReason);
1365 } 1366 }
1366 1367
1367 } // namespace blink 1368 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698