Fix Ruby visual rects in flipped blocks writing mode.

third_party/WebKit/Source/core/layout/LayoutBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 2084 matching lines @@
         // include a scale.
         rect = LayoutRect(layer()->transform()->mapRect(enclosingIntRect(rect)));
     }
     LayoutPoint topLeft = rect.location();
     if (container->isBox()) {
         topLeft.moveBy(topLeftLocation(toLayoutBox(container)));
         // If the row is the ancestor, however, add its offset back in. In effect, this passes from the joint <td> / <tr>
         // coordinate space to the parent space, then back to <tr> / <td>.
         if (tableRowContainer)
             topLeft.moveBy(-tableRowContainer->topLeftLocation(toLayoutBox(container)));
+    } else if (container->isRuby()) {
+        topLeft.moveBy(topLeftLocation());

[wkorman, 2016/07/20 22:12:33]

This was needed to apply offset resulting from any inline blocks that may
precede this one. Note the containing block is not the same as the container in
the relevant ruby case. Ideally we would pass the containing block in to
topLeftLocation() but we actually do not have it currently. Given this is only
done for Ruby, I think it's ok, but open to thoughts.

Here is logging snippet:

[1:1:0720/142316:1042318094031:ERROR:LayoutBox.cpp(2129)] obj="LayoutRubyRun
(anonymous)", container="LayoutRuby (inline) RUBY", container->isBox()=0,
containingBlock="LayoutBlockFlow DIV", origTopLeft="20.000000,2.000000",
topLeftLocation="0.000000,7.000000", inputRect="20.000000,2.000000
12.000000x4.000000", outputRect="20.000000,2.000000 12.000000x4.000000"

for the LayoutRubyRun in layout tree as below:

  LayoutBlockFlow {HTML} at (0,0) size 800x31
    LayoutBlockFlow {BODY} at (8,8) size 784x15
      LayoutBlockFlow {DIV} at (0,0) size 32x15
        LayoutText {#text} at (12,0) size 19x7
          text run at (12,0) width 7: "a"
        LayoutRuby (inline) {RUBY} at (0,0) size 19x8
          LayoutRubyRun (anonymous) at (12,7) size 20x8
            LayoutRubyText {RT} at (-12,0) size 12x8
              LayoutText {#text} at (0,2) size 12x4
                text run at (0,2) width 4: "c"
            LayoutRubyBase (anonymous) at (0,0) size 20x8
              LayoutText {#text} at (0,0) size 19x8
                text run at (0,0) width 8: "b"
        LayoutText {#text} at (0,0) size 0x0

     } else {
         topLeft.moveBy(location());
     }
 
     const ComputedStyle& styleToUse = styleRef();
     EPosition position = styleToUse.position();
     if (position == AbsolutePosition && container->isInFlowPositioned() && container->isLayoutInline()) {
         topLeft += toLayoutInline(container)->offsetForInFlowPositionedInline(*this);
     } else if (styleToUse.hasInFlowPosition() && layer()) {
         // Apply the relative position offset when invalidating a rectangle.  The layer
@@ skipping 2847 matching lines @@
         m_rareData->m_snapAreas->remove(&snapArea);
     }
 }
 
 SnapAreaSet* LayoutBox::snapAreas() const
 {
     return m_rareData ? m_rareData->m_snapAreas.get() : nullptr;
 }
 
 } // namespace blink