gm/tests/outputs/pipe-playback-failure/output-expected/stderr - Issue 21669004: Support multiple PDF rendering backends in the GM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gm/tests/outputs/pipe-playback-failure/output-expected/stderr

Issue 21669004: Support multiple PDF rendering backends in the GM (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: More style fixes Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	1 GM: FAILED to write bitmap: gm/tests/outputs/pipe-playback-failure/output-actual /mismatchPath/comparison/selftest1-pipe.png
	epoger 2013/08/14 19:45:59 Do you know why this changed? Seems surprising to Do you know why this changed? Seems surprising to me... this is the only stderr file that changed in this CL. ducky 2013/08/14 19:56:42 I actually looked into this issue - it was one of Show quoted text On 2013/08/14 19:45:59, epoger wrote: > Do you know why this changed? Seems surprising to me... this is the only stderr > file that changed in this CL. I actually looked into this issue - it was one of the most confusing ones. My best guess is that this failure was always happening, however, it only shows up now that I've moved the error reporting into write_bitmap. Since the style for the rest of the code (well, the test_drawing path, at least) seems to be check conditions before writing the bitmap, I think this sounds reasonable. A future refactor job might be able to address the core issue behind this.
1 GM: ---- comparison/selftest1-pipe.png: 60000 (of 60000) differing pixels, max p er-channel mismatch R=135 G=246 B=135 A=0	2 GM: ---- comparison/selftest1-pipe.png: 60000 (of 60000) differing pixels, max p er-channel mismatch R=135 G=246 B=135 A=0

OLD	NEW