aura: Fix IME interaction in content-shell in chromeos build.

aura: Fix IME interaction in content-shell in chromeos build.

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596
Committed: https://crrev.com/e0a5b1e243a15dd9d6974953b41000e7131dda8d
Cr-Commit-Position: refs/heads/master@{#406740}

[sadrul, 2016-07-20 16:35:29]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 16:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-07-20 16:36:04]

Description was changed from

==========
aura: Fix IME interaction in content-shell.

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596
==========

to

==========
aura: Fix IME interaction in content-shell in chromeos build.

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596
==========

[commit-bot: I haz the power, 2016-07-20 19:04:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:04:35]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-07-20 19:19:10]

sadrul@chromium.org changed reviewers:
+ shuchen@chromium.org

[Shu Chen, 2016-07-21 00:24:02]

lgtm

[Shu Chen, 2016-07-21 00:28:53]

https://codereview.chromium.org/2166863002/diff/1/ui/aura/test/input_method_g...
File ui/aura/test/input_method_glue.h (right):

https://codereview.chromium.org/2166863002/diff/1/ui/aura/test/input_method_g...
ui/aura/test/input_method_glue.h:26: ui::EventDispatchDetails
DispatchKeyEventPostIME(ui::KeyEvent* key) override;
Why does InputMethodGlue need to inherit from InputMethodDelegate, and why this
override is necessary?

[sadrul, 2016-07-21 00:51:32]

https://codereview.chromium.org/2166863002/diff/1/ui/aura/test/input_method_g...
File ui/aura/test/input_method_glue.h (right):

https://codereview.chromium.org/2166863002/diff/1/ui/aura/test/input_method_g...
ui/aura/test/input_method_glue.h:26: ui::EventDispatchDetails
DispatchKeyEventPostIME(ui::KeyEvent* key) override;
On 2016/07/21 00:28:53, Shu Chen wrote:
> Why does InputMethodGlue need to inherit from InputMethodDelegate, and why
this
> override is necessary?

The override dispatches the event back to the WindowTreeHost, which is what's
supposed to happen. The override here is to make sure this Glue does not attempt
to process the event again (this is aking to SetPostIME used in ash:
https://cs.chromium.org/chromium/src/ash/ime/input_method_event_handler.cc?sq...)

[sadrul, 2016-07-21 01:31:41]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:31:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 01:36:59]

Description was changed from

==========
aura: Fix IME interaction in content-shell in chromeos build.

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596
==========

to

==========
aura: Fix IME interaction in content-shell in chromeos build.

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596
==========

[commit-bot: I haz the power, 2016-07-21 01:37:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-21 01:40:19]

Description was changed from

==========
aura: Fix IME interaction in content-shell in chromeos build.

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596
==========

to

==========
aura: Fix IME interaction in content-shell in chromeos build.

Make sure the key events received by the aura::WindowTreeHost instance goes
through the IME, so that text input works correctly.

BUG=629596

Committed: https://crrev.com/e0a5b1e243a15dd9d6974953b41000e7131dda8d
Cr-Commit-Position: refs/heads/master@{#406740}
==========

[commit-bot: I haz the power, 2016-07-21 01:40:20]

Patchset 1 (id:??) landed as
https://crrev.com/e0a5b1e243a15dd9d6974953b41000e7131dda8d
Cr-Commit-Position: refs/heads/master@{#406740}